| commit | 10f9f1fbed11e520e6fd71f02cd71f0e9c759b69 | |
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Fri, 8 Nov 2019 14:11:34 +0000 (8 15:11 +0100) | ||
| committer | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Tue, 19 Nov 2019 13:45:58 +0000 (19 14:45 +0100) | ||
| tree | 138028d0bfcca678dea1da63bde346cf4fde8ffd | treesnapshot (tar.gz zip) |
| parent | 385e43e6638464009e09cfaec254012e531f6342 | commitdiff |
hw/block/pflash: Remove dynamic field width from trace events
Since not all trace backends support dynamic field width in
format (dtrace via stap does not), replace by a static field
width instead.
We previously passed to the trace API 'width << 1' as the number
of hex characters to display (the dynamic field width). We don't
need this anymore. Instead, display the size of bytes accessed.
Fixes: e8aa2d95ea ("pflash: Simplify trace_pflash_io_read/write")
Fixes: c1474acd5d ("pflash: Simplify trace_pflash_data_read/write")
Reported-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Since not all trace backends support dynamic field width in
format (dtrace via stap does not), replace by a static field
width instead.
We previously passed to the trace API 'width << 1' as the number
of hex characters to display (the dynamic field width). We don't
need this anymore. Instead, display the size of bytes accessed.
Fixes: e8aa2d95ea ("pflash: Simplify trace_pflash_io_read/write")
Fixes: c1474acd5d ("pflash: Simplify trace_pflash_data_read/write")
Reported-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| hw/block/pflash_cfi01.c | diffblobblamehistory | |
| hw/block/pflash_cfi02.c | diffblobblamehistory | |
| hw/block/trace-events | diffblobblamehistory |