migration/multifd: Join all multifd threads in order to avoid leaks
commit10351fbad1ee1c1827073c8b2bd644fc897c8ceb
authorLeonardo Bras <leobras@redhat.com>
Fri, 10 Feb 2023 06:36:30 +0000 (10 03:36 -0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 13 Feb 2023 02:45:34 +0000 (13 03:45 +0100)
treec73802d2c0109ca2822d62f0d0e0ec1e2936bac4
parentd926f3bb2a84fdb746678629279a143f568c3c86
migration/multifd: Join all multifd threads in order to avoid leaks

Current approach will only join threads that are still running.

For the threads not joined, resources or private memory are always kept in
the process space and never reclaimed before process end, and this risks
serious memory leaks.

This should usually not represent a big problem, since multifd migration
is usually just ran at most a few times, and after it succeeds there is
not much to be done before exiting the process.

Yet still, it should not hurt performance to join all of them.

Fixes: b5eea99ec2 ("migration: Add yank feature")
Reported-by: Li Xiaohui <xiaohli@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/multifd.c