| commit | 1028283c60e6e35911bb80b959a533b4af1b8b65 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 17 Oct 2018 08:26:35 +0000 (17 10:26 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 19 Oct 2018 12:51:34 +0000 (19 14:51 +0200) | ||
| tree | 392fec3e8109c797cf47c5e21bad4c229f8fadd7 | treesnapshot (tar.gz zip) |
| parent | 11ab69d6e7a81c35f109a399a39d56e777f41d8a | commitdiff |
smbios: Clean up error handling in smbios_add()
Calling error_report() in a function that takes an Error ** argument
is suspicious. smbios_entry_add() does that, and then exit()s. It
also passes &error_fatal to qemu_opts_validate(). Both wrong, but
currently harmless, as its only caller passes &error_fatal. Messed up
in commit 1007a37e208. Clean it up.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20181017082702.5581-12-armbru@redhat.com>
Calling error_report() in a function that takes an Error ** argument
is suspicious. smbios_entry_add() does that, and then exit()s. It
also passes &error_fatal to qemu_opts_validate(). Both wrong, but
currently harmless, as its only caller passes &error_fatal. Messed up
in commit 1007a37e208. Clean it up.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20181017082702.5581-12-armbru@redhat.com>
| hw/smbios/smbios.c | diffblobblamehistory |