hw/intc/arm_gicv3: GICD_TYPER.SecurityExtn is RAZ if GICD_CTLR.DS == 1
commit0edfcc9ec06fbbcc154cce64748752a5c565a32c
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 24 May 2019 12:42:48 +0000 (24 13:42 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 17 Jun 2019 14:13:19 +0000 (17 15:13 +0100)
treecbf0438772a74fde51ae90459fdcfbd5416c3ff5
parente40f60730a208338057d51bfc6c98f89af8eab2d
hw/intc/arm_gicv3: GICD_TYPER.SecurityExtn is RAZ if GICD_CTLR.DS == 1

The GICv3 specification says that the GICD_TYPER.SecurityExtn bit
is RAZ if GICD_CTLR.DS is 1. We were incorrectly making it RAZ
if the security extension is unsupported. "Security extension
unsupported" always implies GICD_CTLR.DS == 1, but the guest can
also set DS on a GIC which does support the security extension.
Fix the condition to correctly check the GICD_CTLR.DS bit.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20190524124248.28394-3-peter.maydell@linaro.org
hw/intc/arm_gicv3_dist.c