qdev: Use returned bool to check for failure, Coccinelle part
commit0c0e618d233e3249f6b60678a1b013a2c8d83339
authorMarkus Armbruster <armbru@redhat.com>
Tue, 7 Jul 2020 16:06:00 +0000 (7 18:06 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 10 Jul 2020 13:18:08 +0000 (10 15:18 +0200)
tree792fe551574fb95cd28bc949d3780b9920e4629c
parent73ac1aac398576a30d3468abccbd9568adc1de76
qdev: Use returned bool to check for failure, Coccinelle part

The previous commit enables conversion of

    qdev_prop_set_drive_err(..., &err);
    if (err) {
    ...
    }

to

    if (!qdev_prop_set_drive_err(..., errp)) {
    ...
    }

Coccinelle script:

    @@
    identifier fun = qdev_prop_set_drive_err;
    expression list args;
    typedef Error;
    Error *err;
    @@
    -    fun(args, &err);
    -    if (err)
    +    if (!fun(args, &err))
         {
             ...
         }

One line break tidied up manually.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-33-armbru@redhat.com>
hw/scsi/scsi-bus.c
hw/sd/sd.c
hw/sd/ssi-sd.c