Revert "qapi-events: add 'if' condition to implicit event enum"
commit093e3679517f910cc99f35b2259469472c6df9b8
authorMarkus Armbruster <armbru@redhat.com>
Thu, 14 Feb 2019 15:22:49 +0000 (14 16:22 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 18 Feb 2019 13:44:05 +0000 (18 14:44 +0100)
tree010df41605b2cffd7171441e1bdb49ebb389d317
parent0b69f6f72ce47a37a749b056b6d5ec64c61f11e8
Revert "qapi-events: add 'if' condition to implicit event enum"

This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c.

The commit applied the events' conditions to the members of enum
QAPIEvent.  Awkward, because it renders QAPIEvent unusable in
target-independent code as soon as we make an event target-dependent.
Reverting this has the following effects:

* ui/vnc.c can remain target independent.

* monitor_qapi_event_conf[] doesn't have to muck around with #ifdef.

* query-events again doesn't reflect conditionals.  I'm going to
  deprecate it in favor of query-qmp-schema.

Another option would be to split target-dependent parts off enum
QAPIEvent into a target-dependent enum.  Doesn't seem worthwhile right
now.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190214152251.2073-17-armbru@redhat.com>
scripts/qapi/events.py