| commit | 055569603d150a18e4d976bb58092206f5024814 | |
| author | John Snow <jsnow@redhat.com> | |
| Tue, 16 Feb 2021 02:17:55 +0000 (15 21:17 -0500) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Thu, 18 Feb 2021 18:37:28 +0000 (18 19:37 +0100) | ||
| tree | 3263039fb7a1f8f347a2448dc3b19cbe39d31e94 | treesnapshot (tar.gz zip) |
| parent | 84bece7dd4ce7ca5a36bc996452ebc882f59ae54 | commitdiff |
qapi/introspect.py: guard against ifcond/comment misuse
_tree_to_qlit is called recursively on dict values (isolated from their
keys); at such a point in generating output it is too late to apply an
ifcond. Similarly, comments do not necessarily have a "tidy" place they
can be printed in such a circumstance.
Forbid this usage by renaming "suppress_first_indent" to "dict_value" to
emphasize that indents are suppressed only for the benefit of dict
values; then add an assertion assuring we do not pass ifcond/comments
in this case.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210216021809.134886-6-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Comment wrapped to conform to PEP 8]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
_tree_to_qlit is called recursively on dict values (isolated from their
keys); at such a point in generating output it is too late to apply an
ifcond. Similarly, comments do not necessarily have a "tidy" place they
can be printed in such a circumstance.
Forbid this usage by renaming "suppress_first_indent" to "dict_value" to
emphasize that indents are suppressed only for the benefit of dict
values; then add an assertion assuring we do not pass ifcond/comments
in this case.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210216021809.134886-6-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Comment wrapped to conform to PEP 8]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| scripts/qapi/introspect.py | diffblobblamehistory |