qemu-bridge-helper: restrict interface name to IFNAMSIZ
commit03d7712b4bcd47bfe0fe14ba2fffa87e111fa086
authorPrasad J Pandit <pjp@fedoraproject.org>
Tue, 23 Jul 2019 10:47:52 +0000 (23 16:17 +0530)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 30 Jul 2019 20:44:36 +0000 (30 15:44 -0500)
tree9b15cc6df020c5a8feccfdeaca8f24e6c807e62d
parent4482258130f8a54ade448a483599888570e73e92
qemu-bridge-helper: restrict interface name to IFNAMSIZ

The network interface name in Linux is defined to be of size
IFNAMSIZ(=16), including the terminating null('\0') byte.
The same is applied to interface names read from 'bridge.conf'
file to form ACL rules. If user supplied '--br=bridge' name
is not restricted to the same length, it could lead to ACL bypass
issue. Restrict interface name to IFNAMSIZ, including null byte.

Reported-by: Riccardo Schirone <rschiron@redhat.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 6f5d8671225dc77190647f18a27a0d156d4ca97a)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qemu-bridge-helper.c