| commit | 0325e5a37b52dd62d64701e1a247760bb6258c35 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 4 Dec 2019 09:36:19 +0000 (4 10:36 +0100) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Sat, 14 Dec 2019 09:25:50 +0000 (14 10:25 +0100) | ||
| tree | 8e5fe59221b5583def29ba312049b7d489263596 | treesnapshot (tar.gz zip) |
| parent | 3d508334dd2c5f920a1b5221124b6633c3bf8e38 | commitdiff |
s390x/cpumodel: Fix feature property error API violations
s390x-cpu property setters set_feature() and set_feature_group()
dereference @errp when the visitor fails. That's wrong; see the big
comment in error.h. Introduced in commit 0754f60429 "s390x/cpumodel:
expose features and feature groups as properties".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-13-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
s390x-cpu property setters set_feature() and set_feature_group()
dereference @errp when the visitor fails. That's wrong; see the big
comment in error.h. Introduced in commit 0754f60429 "s390x/cpumodel:
expose features and feature groups as properties".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-13-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| target/s390x/cpu_models.c | diffblobblamehistory |