| commit | 012b170173bcaa14b9bc26209e0813311ac78489 | |
| author | Dmitrii Gavrilov <ds-gavr@yandex-team.ru> | |
| Fri, 3 Nov 2023 10:56:02 +0000 (3 13:56 +0300) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Fri, 8 Mar 2024 14:51:21 +0000 (8 15:51 +0100) | ||
| tree | 5254158ec2b6b342d6ed72b1f8ae44ac2cf26e94 | treesnapshot (tar.gz zip) |
| parent | 9876359990dd4c8a48de65cf5e1c3d13e96a7f4e | commitdiff |
system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()
Original goal of addition of drain_call_rcu to qmp_device_add was to cover
the failure case of qdev_device_add. It seems call of drain_call_rcu was
misplaced in 7bed89958bfbf40df what led to waiting for pending RCU callbacks
under happy path too. What led to overall performance degradation of
qmp_device_add.
In this patch call of drain_call_rcu moved under handling of failure of
qdev_device_add.
Signed-off-by: Dmitrii Gavrilov <ds-gavr@yandex-team.ru>
Message-ID: <20231103105602.90475-1-ds-gavr@yandex-team.ru>
Fixes: 7bed89958bf ("device_core: use drain_call_rcu in in qmp_device_add", 2020-10-12)
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Original goal of addition of drain_call_rcu to qmp_device_add was to cover
the failure case of qdev_device_add. It seems call of drain_call_rcu was
misplaced in 7bed89958bfbf40df what led to waiting for pending RCU callbacks
under happy path too. What led to overall performance degradation of
qmp_device_add.
In this patch call of drain_call_rcu moved under handling of failure of
qdev_device_add.
Signed-off-by: Dmitrii Gavrilov <ds-gavr@yandex-team.ru>
Message-ID: <20231103105602.90475-1-ds-gavr@yandex-team.ru>
Fixes: 7bed89958bf ("device_core: use drain_call_rcu in in qmp_device_add", 2020-10-12)
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| system/qdev-monitor.c | diffblobblamehistory |