hw/display/omap_lcdc: Fix potential NULL pointer dereference
commit0080edc45e93324e085e93db89180a2945897c5a
authorAlexChen <alex.chen@huawei.com>
Mon, 2 Nov 2020 16:52:17 +0000 (2 16:52 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 2 Nov 2020 16:52:17 +0000 (2 16:52 +0000)
treea8826d31727f358bc2582fb6fe6adb944989c456
parent3f0b59070c89f2261ff5961980ff5203b0c6bea9
hw/display/omap_lcdc: Fix potential NULL pointer dereference

In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before
being check if it is valid, which may lead to NULL pointer dereference.
So move the assignment to surface after checking that the omap_lcd is valid
and move surface_bits_per_pixel(surface) to after the surface assignment.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
Message-id: 5F9CDB8A.9000001@huawei.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/display/omap_lcdc.c