jobs: add exit shim
commit00359a71d45a414ee47d8e423104dc0afd24ec65
authorJohn Snow <jsnow@redhat.com>
Thu, 30 Aug 2018 01:57:28 +0000 (29 21:57 -0400)
committerMax Reitz <mreitz@redhat.com>
Fri, 31 Aug 2018 14:28:33 +0000 (31 16:28 +0200)
tree1ccd72e5f6276dbdd189286785561f0680e3e917
parent3d1f8b07a4c241f81949eff507d9f3a8fd73b87b
jobs: add exit shim

All jobs do the same thing when they leave their running loop:
- Store the return code in a structure
- wait to receive this structure in the main thread
- signal job completion via job_completed

Few jobs do anything beyond exactly this. Consolidate this exit
logic for a net reduction in SLOC.

More seriously, when we utilize job_defer_to_main_loop_bh to call
a function that calls job_completed, job_finalize_single will run
in a context where it has recursively taken the aio_context lock,
which can cause hangs if it puts down a reference that causes a flush.

You can observe this in practice by looking at mirror_exit's careful
placement of job_completed and bdrv_unref calls.

If we centralize job exiting, we can signal job completion from outside
of the aio_context, which should allow for job cleanup code to run with
only one lock, which makes cleanup callbacks less tricky to write.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180830015734.19765-4-jsnow@redhat.com
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
include/qemu/job.h
job.c