| commit | 1cbdde909f70fd15ff85f068a6318b73865c7fa3 | |
| author | Hans de Goede <hdegoede@redhat.com> | |
| Sat, 17 Nov 2012 11:11:50 +0000 (17 12:11 +0100) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Wed, 21 Nov 2012 13:55:54 +0000 (21 14:55 +0100) | ||
| tree | a1b4d15e96d6b6e487fbbf691a6707a99439ca74 | treesnapshot (tar.gz zip) |
| parent | 887938160e5d631c56ee115b1817613a60184138 | commitdiff |
uhci: Don't allow the guest to set port-enabled when there is no dev connected
It is possible for device disconnect and the guest trying to reset the port
(because of USB xact errors prior to the disconnect getting signaled) to race,
when we hit this race, the guest will write the port-control register with its
pre-disconnect value + the reset bit set, after which we have a disconnected
device with its port-enabled bit set in its port-control register, which
is no good :)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
It is possible for device disconnect and the guest trying to reset the port
(because of USB xact errors prior to the disconnect getting signaled) to race,
when we hit this race, the guest will write the port-control register with its
pre-disconnect value + the reset bit set, after which we have a disconnected
device with its port-enabled bit set in its port-control register, which
is no good :)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| hw/usb/hcd-uhci.c | diffblobblamehistory |