repo.or.cz
/
qemu.git
/
search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
log
|
graphiclog1
|
graphiclog2
|
commit
|
commitdiff
|
tree
|
refs
|
edit
|
fork
first
·
prev
·
next
Merge remote-tracking branch 'remotes/amit-migration/tags/for-2.3-2' into staging
2014-11-28
David Gibson
F
ix f
o
r crash aft
e
r migration in virt
i
o-rng
o
n bi-en
d
i
a
n
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-11-04
David
G
ibson
spapr:
Clea
n
up mac
h
in
e
naming conventions, and prepar
e
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-11-04
David Gib
s
on
target-ppc: virte
x
-ml507 machine typ
e
should depend
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-05-30
Davi
d
G
i
b
s
on
v
f
i
o: Add guest s
i
de IOMMU support
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-05-30
David Gibs
o
n
vfio: Create VFIO
A
ddress
S
pace ob
j
ects as needed
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-05-30
D
avi
d
Gibson
vfio: Introduce
V
FIO a
d
dress spaces
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2014-05-30
David Gib
s
o
n
me
m
o
r
y: Sanity ch
e
ck th
a
t
no listeners remain
o
n a
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-10-25
David
G
ibso
n
xics-kvm
:
Supp
o
rt for in
-
kern
e
l XICS i
n
t
errupt controll
e
r
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-10-25
Da
v
id Gibson
target-ppc: Add helpe
r
for KVM_PPC_RTAS_DEFINE
_
TOKEN
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
Acked-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David
Gibson
pseries: s
a
vevm supp
o
rt
f
or PCI h
o
st bridg
e
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David Gi
b
son
pseries: savevm
s
u
p
por
t
f
or
p
series machine
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David
Gibson
pserie
s
:
savev
m
suppor
t
for
PAPR vir
t
ual SCSI
Cc:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David Gibs
o
n
pseries: savevm suppor
t
for
PAPR VIO logical tt
y
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David Gibson
pseries: savevm
s
uppo
r
t for PAPR
VIO logical lan
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-29
David Gibs
o
n
pseries: savevm support for V
I
O devices
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
Dav
i
d
Gibson
p
c
i
:
Fold
h
ost_buses list into PCIH
o
stState function
a
lity
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
David Gibson
p
ci: Re
m
ove domai
n
from
PCIHost
B
us
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
David Gibson
pci: Simpler
impl
e
ment
a
t
i
o
n
of primary PCI bus
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
D
avid
Gibso
n
pci: Add root b
u
s parameter to pci_n
i
c_init()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
D
avid
G
ib
s
o
n
pci: Add r
o
ot bus argument to
pc
i
_get_bus_devfn()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
David
G
ibson
pci: Re
p
la
c
e pci_find_doma
i
n()
w
ith
more ge
n
e
ral
pci_roo
t
_
bu
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
David Gib
s
on
pci:
U
se helper
t
o find dev
i
c
e's roo
t
bus in pci_find
_
d
o
main()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-07
Davi
d
Gibs
o
n
p
c
i: Abolish pc
i
_find_r
o
ot_bus()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-04
D
a
vid Gibson
pci:
M
ove pc
i
_read_devaddr to
p
c
i
-hotplug-old
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-07-04
D
a
v
id Gibs
o
n
pci:
C
l
eanup co
n
figuration fo
r
pci-
h
otplug
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-06-30
David Gibso
n
pseries
:
Update MA
I
NTAINERS information
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-06-30
D
avid Gibson
t
arg
e
t-ppc:
Chan
g
e default machin
e
for 64-bit
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-06-20
D
a
v
id G
i
bson
m
e
mory: Add iommu
map/un
m
ap
notifi
e
rs
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-05-06
David
G
ibson
pseries:
Fix
deb
u
g
m
es
s
age for out
-
of-bo
u
nd
s
a
ddre
s
s
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-05-06
David Gi
b
so
n
ps
e
ri
e
s:
Factor out check
f
or out-o
f
-bounds LIOBN
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
David Gibson
p
s
e
r
ies: G
e
n
erate
d
evice paths for VIO devices
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
David Gibson
pseries:
C
onvert VIO cod
e
to QOM st
y
le t
y
pe safe(
i
sh
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
Da
v
id Gibson
target-ppc: Synchronize VPA s
t
ate with KVM
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
David G
i
bson
ps
e
ries: Fix some small errors in XICS logic
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
D
a
v
i
d Gibson
t
a
rget-ppc:
A
dd more stubs for POWER7
PMU
registe
r
s
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
Da
v
i
d Gibson
pseries: Fixe
s
and enhancements to L1 ca
c
he pr
o
perties
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-04-26
David G
i
bson
pser
i
e
s
: Fi
x
incorrect c
a
lculation of RMA size i
n
c
ertai
n
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-26
David Gibson
savevm:
F
ix bu
g
s
i
n t
h
e VMSTA
T
E
_
VBUFF
E
R_MUL
T
I
P
L
Y
definition
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-26
Davi
d
Gi
b
son
savevm: Add VM
S
TAT
E
_STRU
C
T_V
A
R
RAY_POINTER_UINT32
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-26
David
G
ibson
savevm: Add VMSTATE
_
FLOAT64 helpers
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-26
David Gibson
save
v
m: Add
VMSTA
T
E_UINTTL_EQU
A
L
helper
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-26
David Gibson
s
a
v
evm: Add VMSTATE_UINT64_EQUAL helpers
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Da
v
id Gib
s
on
tar
g
et-p
p
c: Use QOM method dispatch for MM
U
fault ha
n
dling
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David G
i
bs
o
n
t
a
rget-ppc:
M
o
ve ppc tlb_fill
i
mpleme
n
tation
i
nto mmu
_
helper
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David G
i
bson
t
a
rge
t
-pp
c
:
S
plit user onl
y
code out of mmu_helper
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
m
mu-hash6
4
:
I
mp
l
ement Virt
u
al Page Class Key Pr
o
tection
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
a
vid Gibson
m
m
u-hash*: Me
r
ge tran
s
late and f
a
ult ha
n
dling
f
u
n
ct
i
ons
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
m
mu-hash*: D
o
n't use
full ppc_hash{32,
64}
_
t
ra
n
sl
a
t
e
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>`z
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-h
a
sh*: Corre
c
tly mask RPN from
h
ash PTE
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David G
i
bson
mmu-hash*: Cl
e
an
u
p real address calculation
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Davi
d
Gi
b
son
mmu-has
h
*: C
l
ean up PTE flags
u
pdate
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David
G
ibson
mmu-hash
6
4
: Facto
r
S
L
B N
b
i
t
into permission
s
bi
t
s
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Dav
i
d Gib
s
on
mmu-has
h
*:
C
l
e
an up permissi
o
n
c
hecking
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-
h
a
sh3
2
: Rem
o
ve
nx from context structure
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gib
s
on
mmu-hash
*
: Do
n
't
update
PTE
fla
g
s when permiss
i
on is
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mm
u
-has
h
32: Don't look up page tables on B
A
T per
m
ission
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
a
vid
G
i
bson
mmu-hash32: Cleanup BAT lookup
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Da
v
id Gibson
mmu-has
h
32: Clean up BAT mat
c
hing l
o
gic
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
a
vid Gibso
n
mmu-hash32: S
p
lit
BAT size logic from
permissions logic
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Davi
d
Gibson
mmu-hash32:
Remove o
d
d pointer usage from
BAT code
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-has
h
*: F
o
ld pte_check*()
logic int
o
c
a
ller
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David
Gibson
mmu-hash64: Cl
e
an up
p
p
c_hash64_
h
t
a
b_lo
o
kup()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
a
vid G
i
bson
mmu-has
h
*
:
Remove permissi
o
n checking from f
i
nd_pte
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gib
s
o
n
mmu-hash*: Make fin
d
_pte
{
32, 64}
d
o more of the job
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-hash*:
Separate PTEG searc
h
in
g
fr
o
m permissions
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gib
s
o
n
m
m
u-hash*: D
o
n't
k
eep look
i
ng for PTEs
a
fter
w
e find
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
avid
Gibson
m
m
u-hash
*
: Clean
u
p
s
egment-level NX check
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibso
n
mmu-hash32: Split direct
sto
r
e
segment handling i
n
to
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-h
a
sh32: Split o
u
t handling o
f
direct store
segments
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-hash*: Combin
e
ppc_hash{32, 64}_get_physi
c
a
l
_a
d
dress
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibso
n
mm
u
-ha
s
h*: Remove
e
addr field
f
rom mmu_ctx_has
h
{
3
2
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
mmu-hash64: Remove n
x
from mmu_ctx_hash64
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibs
o
n
mmu-ha
s
h*:
Re
d
uce
use
o
f acce
s
s_type
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gib
s
on
m
mu-hash*: A
d
d ha
s
h pte load/s
t
ore helpers
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
m
m
u-hash*: Add
header file for definiti
o
ns
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David
Gibs
o
n
target-ppc: mmu_ct
x
_t
s
hou
l
d
no
t
be a global t
y
pe
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibs
o
n
tar
g
et-ppc: Disen
t
ang
l
e BAT code for
3
2-bi
t
hash M
M
Us
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-ppc: Don't share get_pte
g
_offset() b
e
tween 32
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David G
i
bson
target-ppc: Disentangle hash
m
mu helper f
u
n
ction
s
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-ppc
:
Disentangle hash mmu versi
o
ns of cpu_ge
t
_phys_pa
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
t
a
r
g
et-ppc: Dis
e
ntangle hash mmu p
a
ths for cp
u
_ppc_handle_mm
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-ppc: Disentangle get_ph
y
sical
_
a
d
dress() paths
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
ta
r
get-pp
c
: Rewo
r
k get_physical_addres
s
()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-p
p
c: Dise
n
tan
g
le get_segment()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gi
b
son
target-ppc: Disentangle
find_pte()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Dav
i
d Gi
b
son
t
arg
e
t-ppc: Disen
t
a
ng
l
e pt
e
_check()
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-ppc: M
o
v
e
SLB handling into a mmu
-
ha
s
h
6
4
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David
G
ibson
target-ppc: Remove address c
h
eck
for
l
o
gging
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
D
avid Gibson
target-ppc: T
r
ivi
a
l clea
n
ups in mmu_helper
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
target-ppc: Remove vestigial Power
P
C 620 suppo
r
t
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
p
series: M
o
ve XICS initializa
t
ion before cpu initializa
t
ion
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gibson
ta
r
get-p
p
c: Rem
o
ve CONFIG_
P
SERIES dependency in kvm
.
c
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
David Gib
s
on
pse
r
ies: Re
m
ove "
b
usname
"
property for
P
CI host br
i
dge
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-22
Davi
d
Gib
s
on
pseri
e
s: Fix brea
k
age in CPU
Q
OM conversion
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-15
David Gibson
Fix TAGS creation
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-08
D
a
vid
G
ibso
n
pseries: Add com
p
atible property
t
o r
o
ot of devi
c
e
.
.
.
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-08
David Gibson
target-ppc: Synchronize
F
PU state with KV
M
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-08
David G
i
bson
target-ppc: A
d
d mecha
n
ism f
o
r synchronizi
n
g SPRs with KVM
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-03-08
Da
v
id Gibson
pseries: Add cleanup
hook
f
o
r P
A
PR virtual LA
N
d
evice
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
2013-02-21
David G
i
bson
Add
some missing
q
test binarie
s
to
.
gitignore
Signed-off-by:
David Gibson
<david@gibson.dropbear.id.au>
commit
|
commitdiff
|
tree
next