repo.or.cz
/
qemu.git
/
search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
log
|
graphiclog1
|
graphiclog2
|
commit
|
commitdiff
|
tree
|
refs
|
edit
|
fork
first
·
prev
·
next
Implement qemu_kvm_eat_signals only for CONFIG_LINUX
2011-03-15
Jan Kiszka
Impl
e
me
n
t qe
m
u_kvm_eat_signals
onl
y
for CONFIG_LINUX
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszk
a
kvm: x86: Fail kvm
_
arch_init_vcpu
i
f
M
C
E initialization
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
kvm: x86:
C
l
ean up kvm_setu
p
_mce
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
kvm
:
x86: Consol
i
date TCG and
K
VM
M
CE injection code
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan K
i
szka
x86: Run q
e
mu_in
j
ect_x86
_
mce on target VCPU
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan K
i
szka
kvm
:
x86: Inject pending MCE events on state
writebac
k
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
kvm: Rename kvm_arch_proce
s
s_irqchip
_
event
s
to async_events
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
J
a
n
Kiszka
kvm: x86:
M
o
v
e MCE
functio
n
s to
g
ether
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
Synchronize
V
CPU states before res
e
t
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
x86: Op
t
ionally avoi
d
i
njecting AO
M
C
Es w
h
i
l
e others
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
x86: R
e
fi
n
e er
r
or reporting of MCE i
n
jection services
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan K
i
szka
x86: Small clea
n
ups of
MCE
he
l
pers
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Ja
n
Kiszk
a
x86: Perfo
r
m implicit m
c
g_sta
t
u
s
r
e
set
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan Kiszka
x86:
A
ccount for
MCE
i
n cp
u
_
h
as_
w
ork
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan
K
iszka
kvm:
F
ix build warnin
g
wh
e
n KVM_CAP_SET_GUEST_DEBUG
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-15
Jan K
i
szka
kvm: ppc: Fix
b
reakage
o
f kvm
_
a
r
ch
_
pre_run/pr
o
c
e
s
s
_irqchi
p
_e
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-03-13
Jan Kis
z
ka
Refactor thread r
e
t
riev
a
l a
n
d che
c
k
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-21
Jan Kiszka
i
sa-bus: Remove bogus
IRQ shar
i
ng ch
e
ck
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kis
z
ka
kvm:
x
86:
Introdu
c
e
kvmcloc
k
devi
c
e to
s
ave/restore
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm: M
a
ke kvm_state globally
av
a
i
lable
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n
K
iszka
cirrus: Rem
o
ve
o
bsolete kvm
.
h
inc
l
ud
e
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kis
z
ka
kvm
:
R
e
move u
n
needed
m
emory slot reservation
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm
:
x86: Catch a
n
d report fai
l
ing IRQ
and NMI i
n
jecti
o
ns
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Ja
n
Ki
s
zka
kvm:
Dro
p
ret
u
rn values from kvm_arch_
p
re/post_ru
n
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kisz
k
a
kv
m
:
x
86: Pr
e
p
are VCPU
l
oop f
o
r in-ker
n
el
i
r
q
chip
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm
:
Separate TCG from
KVM cpu exe
c
ution
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan
K
iszka
Mo
v
e
deb
u
g exce
p
tion h
a
ndl
i
ng o
u
t
o
f
cpu_e
x
ec
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kisz
k
a
Refactor debug and
vm
s
to
p
request interface
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
Imp
r
o
v
e vm_stop reason declarations
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
Fix a fe
w
coding style
violations i
n
cpus
.
c
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n Kiszka
Refactor cp
u
_has_work/an
y
_
cpu_has_work in
c
pus
.
c
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan
K
iszk
a
Refactor kvm&tcg function names in cpus
.
c
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm:
L
eave kvm_cpu_ex
e
c directly after KVM_EXIT_SHUTDOWN
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm: Remov
e
static return co
d
e of kvm_handle_io
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n
Kiszka
kvm: Un
c
onditionally reenter k
e
rnel after
I
O exits
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan
Kiszka
Introduce VCPU
self-si
g
naling service
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n Kisz
k
a
kvm
:
Add MCE
signal suppor
t
for
!
C
ONFIG_IO
T
HREAD
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm: Fix race between
t
imer sign
a
ls
and vcpu entry
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n
Kiszka
Set up signalfd under !CONFIG_
I
OTHREA
D
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kis
z
ka
kvm:
C
all qemu_kvm_eat_signals
a
lso under !C
O
NFIG_IOTHR
E
AD
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
k
vm: Re
f
actor q
e
mu_kvm_ea
t
_si
g
nals
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n Kiszka
k
v
m: Set
u
p
signal mas
k
also for !CONF
I
G
_
IOTHREAD
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kis
z
ka
R
e
facto
r
s
ignal s
e
tup functions in
c
pus
.
c
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kv
m
: Provide
si
g
b
u
s ser
v
ices
a
r
ch-independ
e
ntly
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Kiszka
kvm
:
H
a
n
dle
k
vm_init_vcpu e
r
rors
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
an
Kiszka
kvm: Drop redundant kvm_enabled fr
o
m kvm_cpu_thread_fn
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan
Kiszka
kvm
:
Re
p
ort proper e
r
ror on GET_VCPU_
M
MAP_SIZE failures
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
an Kiszka
Flatten the main loop
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
an Kisz
k
a
Leave inner main_loop fa
s
ter on pending requests
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
J
a
n
Kiszka
T
rigger exit
f
rom c
p
u
_
e
xec_all on pending IO even
t
s
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan K
i
sz
k
a
Process vms
t
op requests in IO
thread
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan Ki
s
zka
Stop cu
r
rent
VCPU on synchronous reset
r
e
quests
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-14
Jan
K
isz
k
a
Prevent
abortion on multiple VCPU kicks
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-08
J
a
n Kiszka
x86: Fi
x
MCA
broadcast parame
t
ers
f
or
TC
G
case
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-04
Jan Ki
s
zka
i
o
ap
i
c: Style & magics cl
e
anup
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-04
Jan Kisz
k
a
ioapic: Add support fo
r
qemu-kvm's vm
s
tate v2
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-04
Jan Kiszka
ioapic: Save/restore irr
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-02-04
Ja
n
Kisz
k
a
ioapic: I
m
plemen
t
EOI handl
i
ng for
l
evel-triggered
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm: x
8
6
:
O
nly read/w
r
ite M
S
R_KVM_ASY
N
C
_PF_EN if supported
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm: x86: I
m
plic
i
tly clear nmi_i
n
jected
/
pendin
g
on
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
J
a
n Kisz
k
a
kvm: Do not use
qemu
_
fair_
m
ute
x
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Ja
n
K
i
szka
k
vm: Flus
h
coalesced
m
mio buffer on IO window e
x
its
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm:
x
8
6: Rew
o
rk
i
d
entity map and TSS setup for
l
a
r
ger
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
J
an Kiszka
kvm
:
Cons
o
lidate must-have capabi
l
ity checks
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszk
a
kvm: Dr
o
p smp_cpus argum
e
n
t from in
i
t functions
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan K
i
sz
k
a
kvm: x
8
6: Fix !CONFIG_
K
VM_P
A
R
A build
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Ja
n
Ki
s
zka
kv
m
: x86: R
e
set
paravi
r
tual MSRs
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm: x86: Re
f
actor msr
_
star/hsave_pa
s
etu
p
and checks
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
J
a
n Kiszka
kvm: x
8
6: F
i
x xcr0 reset misme
r
ge
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm: x8
6
: Remove redundant mp_state initialization
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
J
a
n Kiszka
kvm: x86:
P
r
epare
k
vm
_
g
e
t_mp_state for in-kernel ir
q
chip
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Ki
s
zka
kvm: x86
:
Align kvm
_
arch_
p
ut_r
e
giste
r
s code w
i
th comme
n
t
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan
K
iszk
a
x86:
Optionally dump
c
ode bytes o
n
cpu_dump_sta
t
e
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Ja
n
Kiszka
kvm: Improve reporting of fatal errors
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kvm: Stop on all
f
atal e
x
it reasons
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-23
Jan Kiszka
kv
m
:
x
86: S
w
a
l
low KVM_E
X
I
T
_SE
T
_
T
P
R
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Kiszka
c
h
e
ckp
a
tch: Fix bracing false pos
i
tives on #e
l
s
e
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Kiszka
kv
m
: Fix coding styl
e
violati
o
ns
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Kiszka
kvm: x86: Fix
a few coding style violations
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Kiszka
kvm
:
x86: Prevent
s
i
gn extension o
f
DR7 in guest debugging
.
.
.
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Kiszka
k
vm: x86:
Remove o
b
sole
t
e SS
.
RPL/DPL aligment
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2011-01-21
Jan Ki
s
z
k
a
k
v
m: x86
:
Fix DPL
write back of segment regis
t
ers
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-12-27
Jan Kis
z
ka
x
8
6: Filter out gar
b
age from se
g
ment
flags
dump
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-11-21
Jan Kiszka
pcnet:
D
o not re
c
eive ext
e
r
n
al frames in loopback mode
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-10-22
Jan Ki
s
z
k
a
Fix test
suite build with
tracing ena
b
led
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-10-22
Jan
Ki
s
zka
Sil
e
nce com
p
il
e
r
warning i
n
json test case
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kiszka
scsi: Dequ
e
ue
r
equests before invok
i
ng comp
l
etion callback
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kiszka
Rework debug excep
t
ion processin
g
for gdb use
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kiszka
Rename tcg_cpu_e
x
ec and tcg_has_wo
r
k
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan
K
iszk
a
D
rop redundan
t
global
cu
r
_cpu
v
ariable
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Ki
s
zka
Fix qem
u
_
wait_io_event processing in io-thre
a
d
m
o
d
e
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kis
z
ka
Fix cpu_exi
t
for
tcp_cp
u
_exec
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan
K
iszka
Init qemu_syste
m
_
cond
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kiszka
Fix cpu_unl
i
nk_tb race
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-22
Jan Kisz
k
a
Introd
u
ce pro
p
er co
m
piler b
a
rri
e
r
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-06
Jan Kiszka
scsi: Fix SC
S
I bus reset
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-06
Jan Kiszka
Fix
i
o
-thread b
u
i
l
d
b
reakage
of a88790a14f
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-01
J
a
n Kiszk
a
m
onitor: All
o
w t
o
e
xclu
d
e comma
n
ds from Q
M
P
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-01
Jan Kiszka
QMP: Fix python he
l
per /wrt l
o
ng return strings
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
2010-07-01
Jan Kiszk
a
QMP
:
T
e
ach basic
c
apability negotiat
i
on to python exa
m
ple
Signed-off-by:
Jan Kiszka
<jan.kiszka@siemens.com>
commit
|
commitdiff
|
tree
next