From f2dd89d0c7e5d39237f43392ccaed79bda47a71e Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Mon, 18 Apr 2011 19:07:12 +0100 Subject: [PATCH] target-arm: Handle UNDEF cases for Neon VLD/VST multiple-structures Correctly UNDEF for Neon VLD/VST "multiple structures" forms where the align field is not valid. Signed-off-by: Peter Maydell Signed-off-by: Aurelien Jarno --- target-arm/translate.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/target-arm/translate.c b/target-arm/translate.c index 80b25ac5c4..8b309d48b8 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -3830,6 +3830,21 @@ static int disas_neon_ls_insn(CPUState * env, DisasContext *s, uint32_t insn) size = (insn >> 6) & 3; if (op > 10) return 1; + /* Catch UNDEF cases for bad values of align field */ + switch (op & 0xc) { + case 4: + if (((insn >> 5) & 1) == 1) { + return 1; + } + break; + case 8: + if (((insn >> 4) & 3) == 3) { + return 1; + } + break; + default: + break; + } nregs = neon_ls_element_type[op].nregs; interleave = neon_ls_element_type[op].interleave; spacing = neon_ls_element_type[op].spacing; -- 2.11.4.GIT