From a1f910875668d87e139e79fce38e9c2e1c3747dd Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Mon, 9 Jan 2017 17:05:21 +0000 Subject: [PATCH] hw/i386/kvmvapic: Remove dead code in patch_hypercalls() The patch_hypercalls() function sets up a 'patches' variable and checks it at the end of the function, but never modifies it in the middle. Remove this dead code, which seems to have been present since the function was added in commit e5ad936b0fd7 in 2012. (Spotted by Coverity: CID 1005581.) Signed-off-by: Peter Maydell Acked-by: Jan Kiszka Signed-off-by: Michael Tokarev --- hw/i386/kvmvapic.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 2f767b620e..702e281dc8 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -535,7 +535,6 @@ static int patch_hypercalls(VAPICROMState *s) uint8_t alternates[2]; const uint8_t *pattern; const uint8_t *patch; - int patches = 0; off_t pos; uint8_t *rom; @@ -566,11 +565,6 @@ static int patch_hypercalls(VAPICROMState *s) } g_free(rom); - - if (patches != 0 && patches != 2) { - return -1; - } - return 0; } -- 2.11.4.GIT