From 522abf69995ca20680ab048cad003796be36ef77 Mon Sep 17 00:00:00 2001 From: Gonglei Date: Wed, 29 Oct 2014 20:49:43 +0800 Subject: [PATCH] vl.c: Fix Coverity complaining for vmstate_dump_file commit abfd9ce3(migration: dump vmstate info as a json file for static analysis) introduce a new command, '-dump-vmstate', that takes a filename as an argument. When executed, QEMU will dump the vmstate information for the machine type it's invoked with to the file, and quit. However, only one instance of the -dump-vmstate option is supported. If more were given, the vmstate_dump_file variable would be overwritten. This fix also helps silence a Coverity error. Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- vl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index f5721d1f25..f070c90826 100644 --- a/vl.c +++ b/vl.c @@ -3750,6 +3750,11 @@ int main(int argc, char **argv, char **envp) configure_msg(opts); break; case QEMU_OPTION_dump_vmstate: + if (vmstate_dump_file) { + fprintf(stderr, "qemu: only one '-dump-vmstate' " + "option may be given\n"); + exit(1); + } vmstate_dump_file = fopen(optarg, "w"); if (vmstate_dump_file == NULL) { fprintf(stderr, "open %s: %s\n", optarg, strerror(errno)); -- 2.11.4.GIT