qmp: allow setting properties to empty string in qmp-shell
commitf880cd6b6f3fe7847cde3bec1fa98891c92229d2
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 2 Mar 2017 12:24:29 +0000 (2 12:24 +0000)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 16 Mar 2017 06:13:01 +0000 (16 07:13 +0100)
tree22b8087806a1a0cae675e9b22d1c864fdc2e2ca5
parent597494abdefc68991b41cfda03801a496c9fcc4e
qmp: allow setting properties to empty string in qmp-shell

The qmp-shell property parser currently rejects attempts to
set string properties to the empty string eg

  (QEMU) migrate-set-parameters  tls-hostname=
  Error while parsing command line: Expected a key=value pair, got 'tls-hostname='
command format: <command-name>  [arg-name1=arg1] ... [arg-nameN=argN]

This is caused by checking the wrong condition after splitting
the parameter on '='. The "partition" method will return "" for
the separator field, if the seperator was not present, so that
is the correct thing to check for malformed syntax.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <20170302122429.7737-1-berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
scripts/qmp/qmp-shell