qemu-iotests: fix cleanup of background processes
commitf6c8c2e055f88e8ed74ac0c185fc9fbca1e1b775
authorJeff Cody <jcody@redhat.com>
Fri, 30 Oct 2015 19:25:17 +0000 (30 15:25 -0400)
committerMax Reitz <mreitz@redhat.com>
Wed, 11 Nov 2015 15:55:28 +0000 (11 16:55 +0100)
tree6e6d7147a600244e9d116957d7636eadf8c8d8ef
parenta9ecfa004f2dd83df612daac4a87dfc3a0feba28
qemu-iotests: fix cleanup of background processes

Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
subshell, in order to catch segfaults.  Unfortunately, this means the
process PID cannot be captured via '$!'. We stopped killing qemu and
qemu-nbd processes, leaving a lot of orphaned, running qemu processes
after executing iotests.

Since the process is using exec in the subshell, the PID is the
same as the subshell PID.

Track these PIDs for cleanup using pidfiles in the $TEST_DIR. Only
track the qemu PID, however, if requested - not all usage requires
killing the process.

Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Message-id: 9e4f958b3895b7259b98d845bb46f000ba362869.1446232490.git.jcody@redhat.com
[mreitz@redhat.com: Replaced '! -z "..."' by '-n "..."']
Signed-off-by: Max Reitz <mreitz@redhat.com>
tests/qemu-iotests/058
tests/qemu-iotests/common.config
tests/qemu-iotests/common.qemu
tests/qemu-iotests/common.rc