i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted
commitea96bc629cbd52be98b2967a4b4f72e91dfc3ee4
authorLaszlo Ersek <lersek@redhat.com>
Thu, 28 May 2015 20:04:11 +0000 (28 22:04 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 31 May 2015 18:24:07 +0000 (31 20:24 +0200)
tree9a46c5b7038a092ff89e22b1496873ae89fd8010
parent6cd2234ccbacf2825372142a2658bf318ce2f848
i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
Machine type.

Hence, let us not instantiate the FDC when all of the following apply:
- the machine type is pc-q35-2.4 or later,
- "-device isa-fdc" is not passed on the command line (nor in the config
  file),
- no "-drive if=floppy,..." is requested.

Cc: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: John Snow <jsnow@redhat.com>
Cc: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/i386/pc_q35.c