| commit | e5766eb40453b1d22815fc5482802688ff184006 | |
| author | Gerd Hoffmann <kraxel@redhat.com> | |
| Tue, 14 Mar 2017 08:26:58 +0000 (14 09:26 +0100) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Mon, 27 Mar 2017 10:16:02 +0000 (27 12:16 +0200) | ||
| tree | b2aefaea9564be12e2469b6fb8be64f13cd73754 | treesnapshot (tar.gz zip) |
| parent | 8bce03e39328f0b3a6700efb9edb8b7d7aef629b | commitdiff |
vnc: fix reverse mode
vnc server in reverse mode (qemu -vnc localhost:$nr,reverse) interprets
$nr as display number (i.e. with 5900 offset) in recent qemu versions.
Historical and documented behavior is interpreting $nr as port number
though. So we should bring code and documentation in line.
Given that default listening port for viewers is 5500 the 5900 offset is
pretty inconvinient, because it is simply impossible to connect to port
5500. So, lets fix the code not the docs.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1489480018-11443-1-git-send-email-kraxel@redhat.com
vnc server in reverse mode (qemu -vnc localhost:$nr,reverse) interprets
$nr as display number (i.e. with 5900 offset) in recent qemu versions.
Historical and documented behavior is interpreting $nr as port number
though. So we should bring code and documentation in line.
Given that default listening port for viewers is 5500 the 5900 offset is
pretty inconvinient, because it is simply impossible to connect to port
5500. So, lets fix the code not the docs.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1489480018-11443-1-git-send-email-kraxel@redhat.com
| ui/vnc.c | diffblobblamehistory |