s390x/event-facility: fix error propagation
commitd6a9858d24df4fc8633e1c3cb7bf928b80b9685c
authorCornelia Huck <cohuck@redhat.com>
Tue, 21 Jan 2020 09:41:00 +0000 (21 10:41 +0100)
committerCornelia Huck <cohuck@redhat.com>
Mon, 27 Jan 2020 11:13:09 +0000 (27 12:13 +0100)
tree411fa0d13618c5333ad8e15a6217043fd0e97f58
parent3c5fd8074335c67777d9391b84f97070c35d9c63
s390x/event-facility: fix error propagation

We currently check (by error) if the passed-in Error pointer errp
is non-null and return after realizing the first child of the
event facility in that case. Symptom is that 'virsh shutdown'
does not work, as the sclpquiesce device is not realized.

Fix this by (correctly) checking the local Error err.

Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Fixes: 3d508334dd2c ("s390x/event-facility: Fix realize() error API violations")
Message-Id: <20200121095506.8537-1-cohuck@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/s390x/event-facility.c