s390x/pci: Always delete and free the release_timer
commitd648a3e62d5e726526f9df283341999792f4fbf9
authorDavid Hildenbrand <david@redhat.com>
Mon, 14 Jan 2019 10:31:07 +0000 (14 11:31 +0100)
committerCornelia Huck <cohuck@redhat.com>
Fri, 18 Jan 2019 10:52:01 +0000 (18 11:52 +0100)
tree45037eac6fe268b77a8ad3c4dfafa685e9f7de3e
parent6069bcdeaceebb91f43bc4762e3f63eee48cd390
s390x/pci: Always delete and free the release_timer

We should always get rid of it. I don't see a reason to keep the timer
alive if the devices are going away. This looks like a memory leak.

(hmp) device_add virtio-mouse-pci,id=test
(hmp) device_del test
-> guest notified, timer pending.
-> guest does not react for some reason (e.g. crash)
-> s390_pcihost_timer_cb(). Timer not pending anymore. qmp_unplug().

-> Device deleted. Timer expired (not pending) but not freed.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190114103110.10909-4-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/s390x/s390-pci-bus.c