| commit | d5aa9e79048bfc42616949391591fe7947574e5d | |
| author | Frederic Barrat <fbarrat@linux.ibm.com> | |
| Mon, 23 May 2022 15:18:59 +0000 (23 17:18 +0200) | ||
| committer | Daniel Henrique Barboza <danielhb413@gmail.com> | |
| Thu, 26 May 2022 20:11:32 +0000 (26 17:11 -0300) | ||
| tree | 6577482a96d6b15eec8bc9dc63c8e5d2dbbd33bb | treesnapshot (tar.gz zip) |
| parent | dd657a35b429e9affa373a0e6162dd930854ba78 | commitdiff |
pnv/xive2: Don't overwrite PC registers when writing TCTXT registers
When writing a register from the TCTXT memory region (4th page within
the IC BAR), we were overwriting the Presentation Controller (PC)
register at the same offset. It looks like a silly cut and paste
error.
We were somehow lucky: the TCTXT registers being touched are
TCTXT_ENx/_SET/_RESET to enable physical threads and the PC registers
at the same offset are either not used by our model or the update was
harmless.
Found through code inspection.
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220523151859.72283-1-fbarrat@linux.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
When writing a register from the TCTXT memory region (4th page within
the IC BAR), we were overwriting the Presentation Controller (PC)
register at the same offset. It looks like a silly cut and paste
error.
We were somehow lucky: the TCTXT registers being touched are
TCTXT_ENx/_SET/_RESET to enable physical threads and the PC registers
at the same offset are either not used by our model or the update was
harmless.
Found through code inspection.
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220523151859.72283-1-fbarrat@linux.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
| hw/intc/pnv_xive2.c | diffblobblamehistory |