| commit | d2289b524e71970ea8ca5602f219cc92b8e5896b | |
| author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | |
| Mon, 8 Aug 2022 12:20:51 +0000 (8 13:20 +0100) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Wed, 17 Aug 2022 17:08:11 +0000 (17 13:08 -0400) | ||
| tree | 48fa641428d2e25a9e8a8449d572796ce8a3f428 | treesnapshot (tar.gz zip) |
| parent | a99fbb003b2558cb4ff426d8144eff7cc1e2d7dc | commitdiff |
hw/cxl: Fix wrong query of target ports
Two issues were present in this code:
1) Check on which register to look in was inverted.
2) Both branches use the _LO register.
Whilst here moved to extract32() rather than hand rolling
the field extraction as simpler and hopefully less error prone.
Fixes Coverity CID: 1488873
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220808122051.14822-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Two issues were present in this code:
1) Check on which register to look in was inverted.
2) Both branches use the _LO register.
Whilst here moved to extract32() rather than hand rolling
the field extraction as simpler and hopefully less error prone.
Fixes Coverity CID: 1488873
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220808122051.14822-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| hw/cxl/cxl-host.c | diffblobblamehistory |