| commit | d0caa3eb539de01043354440ce0a10b1f546cf06 | |
| author | Gonglei <arei.gonglei@huawei.com> | |
| Fri, 31 Oct 2014 06:11:00 +0000 (31 14:11 +0800) | ||
| committer | Michael Tokarev <mjt@tls.msk.ru> | |
| Sun, 2 Nov 2014 07:05:32 +0000 (2 10:05 +0300) | ||
| tree | ac94d61066bd5c3ddca6f080a2d2166377894262 | treesnapshot (tar.gz zip) |
| parent | bb019cf911ee4a152e3b31940d702d7b8a8b8114 | commitdiff |
tap: do not close(fd) in net_init_tap_one
commit 5193e5fb (tap: factor out common tap initialization)
introduce net_init_tap_one(). But it's inappropriate that
we close fd in net_init_tap_one(), we should lay it in the
caller, becuase some callers needn't to close it if we get
the fd by monitor_handle_fd_param().
On the other hand, in other exceptional branches fd isn't
closed, so that's incomplete anyway.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
commit 5193e5fb (tap: factor out common tap initialization)
introduce net_init_tap_one(). But it's inappropriate that
we close fd in net_init_tap_one(), we should lay it in the
caller, becuase some callers needn't to close it if we get
the fd by monitor_handle_fd_param().
On the other hand, in other exceptional branches fd isn't
closed, so that's incomplete anyway.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| net/tap.c | diffblobblamehistory |