virtio: out-of-bounds buffer write on invalid state load
commitcc45995294b92d95319b4782750a3580cabdbc0c
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 3 Apr 2014 16:51:14 +0000 (3 19:51 +0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 5 May 2014 20:15:02 +0000 (5 22:15 +0200)
treebd7eb37bf798d7b34e75d0cdee9c4aa950bca0f3
parenteea750a5623ddac7a61982eec8f1c93481857578
virtio: out-of-bounds buffer write on invalid state load

CVE-2013-4151 QEMU 1.0 out-of-bounds buffer write in
virtio_load@hw/virtio/virtio.c

So we have this code since way back when:

    num = qemu_get_be32(f);

    for (i = 0; i < num; i++) {
        vdev->vq[i].vring.num = qemu_get_be32(f);

array of vqs has size VIRTIO_PCI_QUEUE_MAX, so
on invalid input this will write beyond end of buffer.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
hw/virtio/virtio.c