qtest: Fix crash if SIGABRT during qtest_init()
commitcb201b4872f16dfbce63f8648b2584631e2e965f
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 13 Mar 2014 09:41:34 +0000 (13 10:41 +0100)
committerAndreas Färber <afaerber@suse.de>
Thu, 13 Mar 2014 20:12:07 +0000 (13 21:12 +0100)
treea91a720022a6b37ad8915c9b8a02eec796df8c02
parentf33f991185bccd22963c256437b9d8ea63361ff5
qtest: Fix crash if SIGABRT during qtest_init()

If an assertion fails during qtest_init() the SIGABRT handler is
invoked.  This is the correct behavior since we need to kill the QEMU
process to avoid leaking it when the test dies.

The global_qtest pointer used by the SIGABRT handler is currently only
assigned after qtest_init() returns.  This results in a segfault if an
assertion failure occurs during qtest_init().

Move global_qtest assignment inside qtest_init().  Not pretty but let's
face it - the signal handler depends on global state.

Reported-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
tests/libqtest.c
tests/libqtest.h