dbus-display: fix test race when initializing p2p connection
commitc8ddcdd6886b34d5d55d8d59973280e4c1b49195
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 9 Jun 2022 15:26:47 +0000 (9 19:26 +0400)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 19 Jul 2022 12:35:00 +0000 (19 14:35 +0200)
tree88783665453f5bf329603fef5f534d3b42ce57b5
parent782378973121addeb11b13fd12a6ac2e69faa33f
dbus-display: fix test race when initializing p2p connection

The D-Bus connection starts processing messages before QEMU has the time
to set the object manager server. This is causing dbus-display-test to
fail randomly with:

ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm:
assertion failed
(qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) ==
"dbus-test"): (NULL == "dbus-test") ERROR

Use the delayed message processing flag and method to avoid that
situation.

(the bus connection doesn't need a fix, as the initialization is done
synchronously)

Reported-by: Robinson, Cole <crobinso@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Cole Robinson <crobinso@redhat.com>
Message-Id: <20220609152647.870373-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/dbus.c