docker: ubuntu: Update the package list before installing new ones
commitbeac6a98f6eb271f2520a329ca051313afd70a69
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Thu, 28 Jun 2018 16:46:36 +0000 (28 13:46 -0300)
committerAlex Bennée <alex.bennee@linaro.org>
Thu, 5 Jul 2018 14:59:41 +0000 (5 15:59 +0100)
treec10ac9862bb40e05773ef81b7a5a67c59d24c29c
parent7781afb49cdcc41b5cd06d4daa53aa1bc45f95ac
docker: ubuntu: Update the package list before installing new ones

Since docker caches the different layers, updating the package
list does not invalidate the previous "apt-get update" layer,
and it is likely "apt-get install" hits an outdated repository.

See https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get

This fixes:

  $ make docker-image-ubuntu V=1
  ./tests/docker/docker.py build qemu:ubuntu tests/docker/dockerfiles/ubuntu.docker   --add-current-user
  Sending build context to Docker daemon  3.072kB
  [...]
  E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa_17.0.7-0ubuntu0.16.04.2_amd64.deb  404  Not Found
  E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa-dev_17.0.7-0ubuntu0.16.04.2_amd64.deb  404  Not Found
  E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
  The command '/bin/sh -c apt-get -y install $PACKAGES' returned a non-zero code: 100
  tests/docker/Makefile.include:40: recipe for target 'docker-image-ubuntu' failed
  make: *** [docker-image-ubuntu] Error 1

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
tests/docker/dockerfiles/ubuntu.docker