hw/virtio: move vhd->started check into helper and add FIXME
commitb8f3e6a18de6ad5cb668c5430b4933f1e40783cf
authorAlex Bennée <alex.bennee@linaro.org>
Tue, 2 Aug 2022 09:49:59 +0000 (2 10:49 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 7 Oct 2022 13:41:51 +0000 (7 09:41 -0400)
tree5dae60d01c48a72924737b17221176a1020be804
parent9f6bcfd99f46377888059d8539befec9505f57fb
hw/virtio: move vhd->started check into helper and add FIXME

The `started` field is manipulated internally within the vhost code
except for one place, vhost-user-blk via f5b22d06fb (vhost: recheck
dev state in the vhost_migration_log routine). Mark that as a FIXME
because it introduces a potential race. I think the referenced fix
should be tracking its state locally.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220802095010.3330793-12-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Raphael Norwitz <raphael.norwittz@nutanix.com>
hw/block/vhost-user-blk.c
hw/scsi/vhost-scsi.c
hw/scsi/vhost-user-scsi.c
hw/virtio/vhost-user-fs.c
hw/virtio/vhost-user-i2c.c
hw/virtio/vhost-user-rng.c
hw/virtio/vhost-user-vsock.c
hw/virtio/vhost-vsock-common.c
hw/virtio/vhost-vsock.c
include/hw/virtio/vhost.h