vnc: call sasl_server_init() only when required
commitb5dc0d7d565048fcf2767060261d8385805aced1
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Fri, 7 Sep 2018 06:36:34 +0000 (7 10:36 +0400)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 1 Oct 2018 09:29:03 +0000 (1 11:29 +0200)
tree93042f7285976715a5b34ee1834eb517bf6fd0a7
parent6624c38d11d0bdb45579c3cc8c7499af79b20564
vnc: call sasl_server_init() only when required

VNC server is calling sasl_server_init() during startup of QEMU, even
if SASL auth has not been enabled.

This may create undesirable warnings like "Could not find keytab file:
/etc/qemu/krb5.tab" when the user didn't configure SASL on host and
started VNC server.

Instead, only initialize SASL when needed. Note that HMP/QMP "change
vnc" calls vnc_display_open() again, which will initialize SASL if
needed.

Fix assignment in if condition, while touching this code.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1609327

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20180907063634.359-1-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc.c