| commit | b498484ed49ab9d1fcada3468f95dda1a5f59366 | |
| author | Cornelia Huck <cornelia.huck@de.ibm.com> | |
| Wed, 4 Nov 2015 17:40:54 +0000 (4 18:40 +0100) | ||
| committer | Cornelia Huck <cornelia.huck@de.ibm.com> | |
| Wed, 11 Nov 2015 16:21:38 +0000 (11 17:21 +0100) | ||
| tree | 6a09ceff242d677ac896de65ab14dafa5fb35e03 | treesnapshot (tar.gz zip) |
| parent | 3c07587d49458341510360557c849e93e9afaf59 | commitdiff |
s390x/css: sense data endianness
We keep the device's sense data in a byte array (following the
architecture), but the ecws are an array of 32 bit values. If we
just blindly copy the values, the sense data will change from
de-facto BE data to de-facto cpu-endian data, which means we end
up doing an incorrect conversion on LE hosts.
Let's just explicitly convert to cpu-endianness while assembling
the irb.
Reported-by: Andy Lutomirski <luto@kernel.org>
Tested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
We keep the device's sense data in a byte array (following the
architecture), but the ecws are an array of 32 bit values. If we
just blindly copy the values, the sense data will change from
de-facto BE data to de-facto cpu-endian data, which means we end
up doing an incorrect conversion on LE hosts.
Let's just explicitly convert to cpu-endianness while assembling
the irb.
Reported-by: Andy Lutomirski <luto@kernel.org>
Tested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
| hw/s390x/css.c | diffblobblamehistory |