main-loop: Disable GLOBAL_STATE_CODE() assertions
commitb1c073490553f80594b903ceedfc7c1aef6b1b19
authorHanna Reitz <hreitz@redhat.com>
Tue, 29 Mar 2022 09:35:45 +0000 (29 11:35 +0200)
committerHanna Reitz <hreitz@redhat.com>
Tue, 29 Mar 2022 14:30:55 +0000 (29 16:30 +0200)
tree49a7d7b59645ad242d346d6a7870b994abeaa925
parent42a5009d8866f69945b708e98d81582bdbcd504f
main-loop: Disable GLOBAL_STATE_CODE() assertions

These assertions are very useful for developers to find bugs, and so
they have indeed pointed us towards bugs already.  For users, it is not
so useful to find these bugs.  We should probably not enable them in
releases until we are sufficiently certain that they will not fire
during normal operation, unless something is going seriously wrong.

For example, we have received a bug report that you cannot add an NBD
server on a BDS in an I/O thread with `-incoming defer`.  I am sure this
is a real bug that needs investigation, but we do not really have that
time right now, so close to release, and so I would rather disable the
assertions to get time to investigate such reports.

(I am just putting the link as "buglink" below, not "closes", because
disabling the assertion will not fix the likely underlying bug.)

Buglink: https://gitlab.com/qemu-project/qemu/-/issues/945
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220329093545.52114-1-hreitz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
include/qemu/main-loop.h