| commit | 9d0bd0cdd011edf15949ecdf08c25d8385028983 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 5 Feb 2019 17:42:07 +0000 (5 17:42 +0000) | ||
| committer | Laurent Vivier <laurent@vivier.eu> | |
| Thu, 7 Feb 2019 13:11:19 +0000 (7 14:11 +0100) | ||
| tree | b229c629e598868272deb6e5888b2c9b2f085ed7 | treesnapshot (tar.gz zip) |
| parent | 22e4a267a6627e5b5b1b13bfc1b92445775704be | commitdiff |
linux-user: Check sscanf return value in open_net_route()
Coverity warns (CID 1390634) that open_net_route() is not
checking the return value from sscanf(), which means that
it might then use values that aren't initialized.
Errors here should in general not happen since we're passing
an assumed-good /proc/net/route from the host kernel, but
if we do fail to parse a line then just skip it in the output
we pass to the guest.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20190205174207.9278-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Coverity warns (CID 1390634) that open_net_route() is not
checking the return value from sscanf(), which means that
it might then use values that aren't initialized.
Errors here should in general not happen since we're passing
an assumed-good /proc/net/route from the host kernel, but
if we do fail to parse a line then just skip it in the output
we pass to the guest.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20190205174207.9278-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| linux-user/syscall.c | diffblobblamehistory |