m25p80: Improve command handling for unsupported commands
commit9c85bcd8f5f9f775e8305e580cf5fbc5b7ba2c28
authorGuenter Roeck <linux@roeck-us.net>
Mon, 16 Mar 2020 15:52:24 +0000 (16 15:52 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 17 Mar 2020 11:36:42 +0000 (17 11:36 +0000)
treed878721945f4893353581a7e4a711513a804d860
parentf3ee222f0c5f3681c28991313f76773e6cfed777
m25p80: Improve command handling for unsupported commands

Whenever an unsupported command is encountered, the current code
interprets each transferred byte as new command. Most of the time, those
'commands' are interpreted as new unknown commands. However, in rare
cases, it may be that for example address or length information
passed with the original command is by itself a valid command.
If that happens, the state machine may get completely confused and,
worst case, start writing data into the flash or even erase it.

To avoid the problem, transition into STATE_READING_DATA and keep
sending a value of 0 until the chip is deselected after encountering
an unsupported command.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/block/m25p80.c