memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write()
commit99b2c0622513fc98e8ed9dac56cafb6d29240e87
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Tue, 7 Sep 2021 00:47:49 +0000 (6 21:47 -0300)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 29 Sep 2021 09:37:39 +0000 (29 19:37 +1000)
tree847971e0a4ee42c7b432f1775d55ed4bb0773d63
parenta3d67f3e5d5bfe480eeb83d24546191b681b7c38
memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write()

qapi_event_send_mem_unplug_error() deals with @device being NULL by
replacing it with an empty string ("") when emitting the event. Aside
from the fact that this behavior (qapi visitor mapping NULL pointer to
"") can be patched/changed someday, there's also the lack of utility
that the event brings to listeners, e.g. "a memory unplug error happened
somewhere".

In theory we should just avoit emitting this event at all if dev->id is
NULL, but this would be an incompatible change to existing guests.
Instead, let's make the forementioned behavior explicit: if dev->id is
NULL, pass an empty string to qapi_event_send_mem_unplug_error().

Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20210907004755.424931-2-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/acpi/memory_hotplug.c