| commit | 927d811b282ffdf5386bd63f435c1507634ba49a | |
| author | Dunrong Huang <riegamaths@gmail.com> | |
| Fri, 6 Jul 2012 06:04:43 +0000 (6 14:04 +0800) | ||
| committer | Jan Kiszka <jan.kiszka@siemens.com> | |
| Mon, 9 Jul 2012 15:38:13 +0000 (9 17:38 +0200) | ||
| tree | 77d336dbfd5bdf6eab6931e09b53175e9ea978f8 | treesnapshot (tar.gz zip) |
| parent | b412eb61bfd400ad70afe11ac3a5fb2931124804 | commitdiff |
slirp: Ensure smbd and shared directory exist when enable smb
Users may pass the following parameters to qemu:
$ qemu-kvm -net nic -net user,smb= ...
$ qemu-kvm -net nic -net user,smb ...
$ qemu-kvm -net nic -net user,smb=bad_directory ...
In these cases, qemu started successfully while samba server
failed to start. Users will confuse since samba server
failed silently without any indication of what it did wrong.
To avoid it, we check whether the shared directory exist and
if users have permission to access this directory when QEMU's
"built-in" SMB server is enabled.
Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Users may pass the following parameters to qemu:
$ qemu-kvm -net nic -net user,smb= ...
$ qemu-kvm -net nic -net user,smb ...
$ qemu-kvm -net nic -net user,smb=bad_directory ...
In these cases, qemu started successfully while samba server
failed to start. Users will confuse since samba server
failed silently without any indication of what it did wrong.
To avoid it, we check whether the shared directory exist and
if users have permission to access this directory when QEMU's
"built-in" SMB server is enabled.
Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
| net/slirp.c | diffblobblamehistory |