hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure
commit90865af7d901a2aa5eeadfb488f3a9d4aaf70605
authorXuzhou Cheng <xuzhou.cheng@windriver.com>
Tue, 20 Sep 2022 10:31:48 +0000 (20 18:31 +0800)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Tue, 20 Sep 2022 15:31:53 +0000 (20 12:31 -0300)
tree1f6bf3678e3a5124633e7305ed464805924b999c
parentcb5b5ab9a516ce5ecddfc50971bf6f690300fd74
hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure

pnv_phb3_root_bus_info and pnv_phb4_root_bus_info are missing the
instance_size initialization. This results in accessing out-of-bound
memory when setting 'chip-id' and 'phb-id', and eventually crashes
glib's malloc functionality with the following message:

  "qemu-system-ppc64: GLib: ../glib-2.72.3/glib/gmem.c:131: failed to allocate 3232 bytes"

This issue was noticed only when running qtests with QEMU Windows
32-bit executable. Windows 64-bit, Linux 32/64-bit do not expose
this bug though.

Fixes: 9ae1329ee2fe ("ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge")
Fixes: 4f9924c4d4cf ("ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge")
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20220920103159.1865256-29-bmeng.cn@gmail.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
hw/pci-host/pnv_phb3.c
hw/pci-host/pnv_phb4.c