| commit | 85d9d044471f93c48c5c396f7e217b4ef12f69f8 | |
| author | Li Qiang <liqiang6-s@360.cn> | |
| Tue, 1 Nov 2016 12:37:57 +0000 (1 05:37 -0700) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Wed, 11 Jan 2017 08:19:05 +0000 (11 09:19 +0100) | ||
| tree | 8165649602ebe2e1796da2f22b9d2e5e7f7db224 | treesnapshot (tar.gz zip) |
| parent | b44486dfb9447c88e4b216e730adcc780190852c | commitdiff |
virtio-gpu: fix information leak in capset get dispatch
In virgl_cmd_get_capset function, it uses g_malloc to allocate
a response struct to the guest. As the 'resp'struct hasn't been full
initialized it will lead the 'resp->padding' field to the guest.
Use g_malloc0 to avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 58188cae.4a6ec20a.3d2d1.aff2@mx.google.com
[ kraxel: resolved conflict ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
In virgl_cmd_get_capset function, it uses g_malloc to allocate
a response struct to the guest. As the 'resp'struct hasn't been full
initialized it will lead the 'resp->padding' field to the guest.
Use g_malloc0 to avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 58188cae.4a6ec20a.3d2d1.aff2@mx.google.com
[ kraxel: resolved conflict ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| hw/display/virtio-gpu-3d.c | diffblobblamehistory |