| commit | 82e2756897810b6e17e0c352101878b97b1e2688 | |
| author | Greg Kurz <groug@kaod.org> | |
| Tue, 16 Feb 2021 12:02:47 +0000 (16 13:02 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 16 Feb 2021 16:15:39 +0000 (16 17:15 +0100) | ||
| tree | 4aa70d58a480f305030e31437d9493bd300e72d0 | treesnapshot (tar.gz zip) |
| parent | 106f91d59c373b63f227b8827ff18ac9c9068d2f | commitdiff |
event_notifier: Set ->initialized earlier in event_notifier_init()
Otherwise the call to event_notifier_set() is a nop, which causes
the SLOF firmware on POWER to hang when booting from a virtio-scsi
device:
virtio_scsi_dataplane_start()
virtio_scsi_vring_init()
virtio_bus_set_host_notifier() <- assign == true
event_notifier_init() <- active == 1
event_notifier_set() <- fails right away if !e->initialized
Fixes: e34e47eb28c0 ("event_notifier: handle initialization failure better")
Cc: mlevitsk@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210216120247.1293569-1-groug@kaod.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Otherwise the call to event_notifier_set() is a nop, which causes
the SLOF firmware on POWER to hang when booting from a virtio-scsi
device:
virtio_scsi_dataplane_start()
virtio_scsi_vring_init()
virtio_bus_set_host_notifier() <- assign == true
event_notifier_init() <- active == 1
event_notifier_set() <- fails right away if !e->initialized
Fixes: e34e47eb28c0 ("event_notifier: handle initialization failure better")
Cc: mlevitsk@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210216120247.1293569-1-groug@kaod.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| util/event_notifier-posix.c | diffblobblamehistory |