| commit | 7b8a8474249eec97cd6a82f78b91183626fda65b | |
| author | Pankaj Gupta <pagupta@redhat.com> | |
| Fri, 12 Jul 2019 07:35:53 +0000 (12 13:05 +0530) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Fri, 12 Jul 2019 14:56:27 +0000 (12 10:56 -0400) | ||
| tree | 675b6afd6580b7b50454bff170a296ca234009ba | treesnapshot (tar.gz zip) |
| parent | f37f47126236c8dc710d97da8ca9d43c38bef4ec | commitdiff |
virtio pmem: remove memdev null check
Coverity reports that when we're assigning vi->size we handle the
"pmem->memdev is NULL" case; but we then pass it into
object_get_canonical_path(), which unconditionally dereferences it
and will crash if it is NULL. If this pointer can be NULL then we
need to do something else here.
We are removing 'pmem->memdev' null check here as memdev will never
be null in this function.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Message-Id: <20190712073554.21918-3-pagupta@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Coverity reports that when we're assigning vi->size we handle the
"pmem->memdev is NULL" case; but we then pass it into
object_get_canonical_path(), which unconditionally dereferences it
and will crash if it is NULL. If this pointer can be NULL then we
need to do something else here.
We are removing 'pmem->memdev' null check here as memdev will never
be null in this function.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Message-Id: <20190712073554.21918-3-pagupta@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
| hw/virtio/virtio-pmem.c | diffblobblamehistory |