| commit | 740bc3a7e610a2a0daea9af9fd7f45d5e9ed78cc | |
| author | Cédric Le Goater <clg@kaod.org> | |
| Tue, 1 Sep 2020 12:21:50 +0000 (1 14:21 +0200) | ||
| committer | Cédric Le Goater <clg@kaod.org> | |
| Tue, 1 Sep 2020 12:21:50 +0000 (1 14:21 +0200) | ||
| tree | 4eefae5c83b0596de09a2de59e8101c425c6fb36 | treesnapshot (tar.gz zip) |
| parent | 31fc566f5e9cbe36d4fa12d429eff4c634d681b4 | commitdiff |
aspeed/scu: Fix valid access size on AST2400
The read access size of the SCU registers can be 1/2/4 bytes and write
is 4 bytes and all Aspeed models would need a .valid.accepts() handler.
For the moment, set the min access size to 1 byte to cover both read
and write operations on the AST2400 but keep the min access size of
the other SoCs to 4 bytes as this is an unusual access size.
This fixes support for some old firmware doing 2 bytes reads on the
AST2400 SoC.
Reported-by: Erik Smit <erik.lucas.smit@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Message-Id: <20200819100956.2216690-5-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
The read access size of the SCU registers can be 1/2/4 bytes and write
is 4 bytes and all Aspeed models would need a .valid.accepts() handler.
For the moment, set the min access size to 1 byte to cover both read
and write operations on the AST2400 but keep the min access size of
the other SoCs to 4 bytes as this is an unusual access size.
This fixes support for some old firmware doing 2 bytes reads on the
AST2400 SoC.
Reported-by: Erik Smit <erik.lucas.smit@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Message-Id: <20200819100956.2216690-5-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
| hw/misc/aspeed_scu.c | diffblobblamehistory |