exec: invert return value of cpu_physical_memory_get_clean, rename
commit72b47e79cef36ed6ffc718f10e21001d7ec2a66f
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 22 Apr 2015 11:48:25 +0000 (22 13:48 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 5 Jun 2015 15:09:59 +0000 (5 17:09 +0200)
treedc5d184f90c1339bf632a6e702d732013bcd6d50
parent58d2707e8713ef17b89b8b4c9ce586c76655a385
exec: invert return value of cpu_physical_memory_get_clean, rename

While it is obvious that cpu_physical_memory_get_dirty returns true even if
a single page is dirty, the same is not true for cpu_physical_memory_get_clean;
one would expect that it returns true only if all the pages are clean, but
it actually looks for even one clean page.  (By contrast, the caller of that
function, cpu_physical_memory_range_includes_clean, has a good name).

To clarify, rename the function to cpu_physical_memory_all_dirty and return
true if _all_ the pages are dirty.  This is the opposite of the previous
meaning, because "all are 1" is the same as "not (any is 0)", so we have to
modify cpu_physical_memory_range_includes_clean as well.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/exec/ram_addr.h