| commit | 729315ebca0811c11e937d00231f8e05de5b446d | |
| author | Thomas Huth <thuth@redhat.com> | |
| Thu, 27 Sep 2018 08:23:34 +0000 (27 10:23 +0200) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Thu, 4 Oct 2018 08:32:38 +0000 (4 10:32 +0200) | ||
| tree | 3982ce59ae7062907955724ef7b3a8754a7e4f7c | treesnapshot (tar.gz zip) |
| parent | 3b8afb41bc8eef42c3e2d3ed78ca5fe94ebe76e8 | commitdiff |
hw/s390x/css: Remove QEMU_PACKED from struct SenseId
The uint16_t member cu_type of struct SenseId is not naturally aligned,
and since the struct is marked with QEMU_PACKED, this can lead to
unaligned memory accesses - which does not work on architectures like
Sparc. Thus remove the QEMU_PACKED here and rather copy the struct
byte by byte when we do copy_sense_id_to_guest().
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1538036615-32542-3-git-send-email-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
The uint16_t member cu_type of struct SenseId is not naturally aligned,
and since the struct is marked with QEMU_PACKED, this can lead to
unaligned memory accesses - which does not work on architectures like
Sparc. Thus remove the QEMU_PACKED here and rather copy the struct
byte by byte when we do copy_sense_id_to_guest().
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1538036615-32542-3-git-send-email-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| hw/s390x/css.c | diffblobblamehistory | |
| include/hw/s390x/css.h | diffblobblamehistory |