s390x/css: disabled subchannels cannot be status pending
commit6e9c893ecd00afd5344c35d0d0ded50eaa0938f6
authorCornelia Huck <cohuck@redhat.com>
Fri, 4 May 2018 12:53:16 +0000 (4 14:53 +0200)
committerCornelia Huck <cohuck@redhat.com>
Mon, 14 May 2018 15:10:02 +0000 (14 17:10 +0200)
tree89e06ff4476e533057867d8fd29929d1c8570093
parentbbd87423ea0c436c55bbc3f9c23d4f811d1f3f29
s390x/css: disabled subchannels cannot be status pending

The 3270 code will try to post an attention interrupt when the
3270 emulator (e.g. x3270) attaches. If the guest has not yet
enabled the subchannel for the 3270 device, we will present a spurious
cc 1 (status pending) when it uses msch on it later on, e.g. when
trying to enable the subchannel.

To fix this, just don't do anything in css_conditional_io_interrupt()
if the subchannel is not enabled. The 3270 code will work fine with
that, and the other user of this function (virtio-ccw) never
attempts to post an interrupt for a disabled device to begin with.

CC: qemu-stable@nongnu.org
Reported-by: Thomas Huth <thuth@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/s390x/css.c