pc-bios/s390-ccw: Silence warning from Clang by marking panic() as noreturn
commit679196a646c91b8ce9a97b0aa81ffb3776cf8046
authorThomas Huth <thuth@redhat.com>
Sun, 2 May 2021 11:49:20 +0000 (2 13:49 +0200)
committerThomas Huth <thuth@redhat.com>
Sun, 9 May 2021 16:19:43 +0000 (9 18:19 +0200)
tree38aa549ed988145dac2c1ec12f44de9ac9392976
parentb460a220872c28a8da95cbc7e9369d26aa268848
pc-bios/s390-ccw: Silence warning from Clang by marking panic() as noreturn

When compiling the s390-ccw bios with Clang, the compiler emits a warning:

 pc-bios/s390-ccw/main.c:210:5: warning: variable 'found' is used uninitialized
  whenever switch default is taken [-Wsometimes-uninitialized]
     default:
     ^~~~~~~
 pc-bios/s390-ccw/main.c:214:16: note: uninitialized use occurs here
     IPL_assert(found, "Boot device not found\n");
                ^~~~~

It's a false positive, it only happens because Clang is not smart enough
to see that the panic() function in the "default:" case can never return.

Anyway, let's explicitely mark panic() with "noreturn" to shut up the
warning.

Message-Id: <20210502174836.838816-2-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/s390-ccw.h