| commit | 660a2d83e026496db6b3eaec2256a2cdd6c74de8 | |
| author | Daniel P. Berrange <berrange@redhat.com> | |
| Fri, 30 Sep 2016 15:02:01 +0000 (30 16:02 +0100) | ||
| committer | Michael Tokarev <mjt@tls.msk.ru> | |
| Sat, 8 Oct 2016 08:25:29 +0000 (8 11:25 +0300) | ||
| tree | 51ca0acda319a2bf24aa7d6ebd44fc02f8d9d52d | treesnapshot (tar.gz zip) |
| parent | 56bef8511a576deef32d3e763b993b5001015c2d | commitdiff |
char: fix missing return in error path for chardev TLS init
If the qio_channel_tls_new_(server|client) methods fail,
we disconnect the client. Unfortunately a missing return
means we then go on to try and run the TLS handshake on
a NULL I/O channel. This gives predictably segfaulty
results.
The main way to trigger this is to request a bogus TLS
priority string for the TLS credentials. e.g.
-object tls-creds-x509,id=tls0,priority=wibble,...
Most other ways appear impossible to trigger except
perhaps if OOM conditions cause gnutls initialization
to fail.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
If the qio_channel_tls_new_(server|client) methods fail,
we disconnect the client. Unfortunately a missing return
means we then go on to try and run the TLS handshake on
a NULL I/O channel. This gives predictably segfaulty
results.
The main way to trigger this is to request a bogus TLS
priority string for the TLS credentials. e.g.
-object tls-creds-x509,id=tls0,priority=wibble,...
Most other ways appear impossible to trigger except
perhaps if OOM conditions cause gnutls initialization
to fail.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| qemu-char.c | diffblobblamehistory |