| commit | 5af3a05631daffc61a12dd2c25d15876f048fdd1 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Tue, 7 Jul 2020 16:05:48 +0000 (7 18:05 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 10 Jul 2020 13:18:08 +0000 (10 15:18 +0200) | ||
| tree | b3de89b2640444b98671bf6c5017ac2659114a18 | treesnapshot (tar.gz zip) |
| parent | 14217038bc9e36246d311fa8e026a01a5d7bbd42 | commitdiff |
s390x/pci: Fix harmless mistake in zpci's property fid's setter
s390_pci_set_fid() sets zpci->fid_defined to true even when
visit_type_uint32() failed. Reproducer: "-device zpci,fid=junk".
Harmless in practice, because qdev_device_add() then fails, throwing
away @zpci. Fix it anyway.
Cc: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200707160613.848843-21-armbru@redhat.com>
s390_pci_set_fid() sets zpci->fid_defined to true even when
visit_type_uint32() failed. Reproducer: "-device zpci,fid=junk".
Harmless in practice, because qdev_device_add() then fails, throwing
away @zpci. Fix it anyway.
Cc: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200707160613.848843-21-armbru@redhat.com>
| hw/s390x/s390-pci-bus.c | diffblobblamehistory |